[PATCH] D116686: Revert D109159 : Revert "[amdgpu] Enable selection of `s_cselect_b64`."

David Salinas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 5 11:58:38 PST 2022


david-salinas created this revision.
david-salinas added a reviewer: kzhuravl.
Herald added subscribers: foad, kerbowa, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, arsenm.
david-salinas requested review of this revision.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.

This reverts commit 640beb38e7710b939b3cfb3f4c54accc694b1d30 <https://reviews.llvm.org/rG640beb38e7710b939b3cfb3f4c54accc694b1d30>.

That commit caused performance degradtion in Quicksilver test QS:sGPU and a functional test failure in (rocPRIM rocprim.device_segmented_radix_sort).
Reverting until we have a better solution to s_cselect_b64 codegen cleanup

Change-Id: Ifc167b3c2dae7a65920676f22a97ba76485f3456


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D116686

Files:
  llvm/lib/Target/AMDGPU/SIISelLowering.cpp
  llvm/lib/Target/AMDGPU/SIInstrInfo.cpp
  llvm/lib/Target/AMDGPU/SIInstrInfo.h
  llvm/lib/Target/AMDGPU/SOPInstructions.td
  llvm/test/CodeGen/AMDGPU/addrspacecast.ll
  llvm/test/CodeGen/AMDGPU/amdgpu-codegenprepare-idiv.ll
  llvm/test/CodeGen/AMDGPU/dagcombine-select.ll
  llvm/test/CodeGen/AMDGPU/extract_vector_dynelt.ll
  llvm/test/CodeGen/AMDGPU/extract_vector_elt-f64.ll
  llvm/test/CodeGen/AMDGPU/extract_vector_elt-i64.ll
  llvm/test/CodeGen/AMDGPU/flat-scratch-init.ll
  llvm/test/CodeGen/AMDGPU/indirect-call-known-callees.ll
  llvm/test/CodeGen/AMDGPU/insert_vector_dynelt.ll
  llvm/test/CodeGen/AMDGPU/insert_vector_elt.ll
  llvm/test/CodeGen/AMDGPU/llvm.mulo.ll
  llvm/test/CodeGen/AMDGPU/load-select-ptr.ll
  llvm/test/CodeGen/AMDGPU/select64.ll
  llvm/test/CodeGen/AMDGPU/selectcc.ll
  llvm/test/CodeGen/AMDGPU/sint_to_fp.f64.ll
  llvm/test/CodeGen/AMDGPU/uint_to_fp.f64.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D116686.397659.patch
Type: text/x-patch
Size: 294581 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220105/676ab2f3/attachment-0001.bin>


More information about the llvm-commits mailing list