[PATCH] D116676: [1/4] [llvm-objdump][test] Add RISC-V objdump test case

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 5 11:29:58 PST 2022


MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/ELF/RISCV/branches.s:3
+# RUN:     | llvm-objdump -d -M no-aliases --no-show-raw-insn - \
+# RUN:     | FileCheck --match-full-lines %s
+
----------------
asb wrote:
> MaskRay wrote:
> > Remove `--match-full-lines`
> > 
> > In most test/tools/, the prevailing continuation-line format is to place `|` at the line end.
> > ```
> > # RUN: llvm-mc -filetype=obj -triple riscv32 -mattr=+c %s |
> > # RUN:     llvm-objdump -d -M no-aliases --no-show-raw-insn - |
> > ```
> The reasoning behind --match-full-lines was that it will catch changes to printing of branch targets (as in D116678), ensuring the test case is updated.
An alternative is to add `{{$}}` in a few places where it is significant.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116676/new/

https://reviews.llvm.org/D116676



More information about the llvm-commits mailing list