[PATCH] D116629: Introduce NewPM DOT printers for DomTree

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 5 09:39:20 PST 2022


aeubanks added a comment.

could you fix the lint checks and also add a test (a simple one is fine)



================
Comment at: llvm/include/llvm/Analysis/DOTGraphTraitsPass.h:186
+void WriteDOTGraphToFile(Function &F, GraphT &&Graph,
+                         std::string FileNamePrefix, bool IsSimple = false) {
+  std::string Filename = FileNamePrefix + "." + F.getName().str() + ".dot";
----------------
probably better to make this not have a default argument


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116629/new/

https://reviews.llvm.org/D116629



More information about the llvm-commits mailing list