[PATCH] D116207: [DFSan] Add option for conditional callbacks.

[Matt Morehouse via Phabricator via llvm-commits]

morehouse added inline comments.


================
Comment at: compiler-rt/test/dfsan/conditional_callbacks.c:22
+extern dfsan_label LabelArgv;
+extern size_t LenArgv;
+
----------------
These Argv variables are unused.


================
Comment at: compiler-rt/test/dfsan/conditional_callbacks.c:55
+
+size_t LenArgv;
+
----------------
Unused.


================
Comment at: compiler-rt/test/dfsan/origin_conditional_callbacks.c:22
+extern dfsan_label LabelArgv;
+extern size_t LenArgv;
+
----------------
Argv variables unused again.


================
Comment at: compiler-rt/test/dfsan/origin_conditional_callbacks.c:106
+
+#endif // #ifdef CALLBACKS
----------------
This test is nearly identical to conditional_callbacks.c.  Let's combine them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116207/new/

https://reviews.llvm.org/D116207