[PATCH] D116651: [LegalizeTypes][VP] Add splitting support for vp.select

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 5 08:50:16 PST 2022


craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp:1197
+  case ISD::SELECT:
+    SplitRes_Select(N, Lo, Hi);
+    break;
----------------
Leave the old formatting


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:2276
   case ISD::MERGE_VALUES: SplitRes_MERGE_VALUES(N, ResNo, Lo, Hi); break;
-  case ISD::SELECT:       SplitRes_SELECT(N, Lo, Hi); break;
+  case ISD::SELECT:
+    SplitRes_Select(N, Lo, Hi);
----------------
Leave the old formatting


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeTypes.h:1025
   void SplitRes_ARITH_FENCE (SDNode *N, SDValue &Lo, SDValue &Hi);
-  void SplitRes_SELECT      (SDNode *N, SDValue &Lo, SDValue &Hi);
+  void SplitRes_Select(SDNode *N, SDValue &Lo, SDValue &Hi);
   void SplitRes_SELECT_CC   (SDNode *N, SDValue &Lo, SDValue &Hi);
----------------
Leave the old formatting


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:918
+  case ISD::SELECT:
+  case ISD::VP_SELECT:
+    SplitRes_Select(N, Lo, Hi);
----------------
Leave the old formatting


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116651/new/

https://reviews.llvm.org/D116651



More information about the llvm-commits mailing list