[PATCH] D116589: Don't override __attribute__((no_stack_protector)) by inlining

[Hans Wennborg via Phabricator via llvm-commits]

hans added inline comments.


================
Comment at: llvm/test/Transforms/Inline/inline_ssp.ll:2
 ; RUN: opt -inline %s -S | FileCheck %s
 ; RUN: opt -passes='cgscc(inline)' %s -S | FileCheck %s
 ; Ensure SSP attributes are propagated correctly when inlining.
----------------
hans wrote:
> nickdesaulniers wrote:
> > I think there's a pass called `always-inline`, too. Should we add that as a run line?
> I don't think we'd get any new coverage from that really. The interesting thing to test is the inline case. It's good to have a test case with autoinline too, to make sure they don't diverge in the future, but the inline pass will handle that too.
s/autoinline/alwaysinline/ obviously :-]


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116589/new/

https://reviews.llvm.org/D116589