[PATCH] D116603: [AIX][z/OS][Support] Provide no-op mapped_file_region::dontNeedImpl implementation

[David Tenty via Phabricator via llvm-commits]

daltenty added inline comments.


================
Comment at: llvm/lib/Support/Unix/Path.inc:878
+#else
   if (Mapping)
     ::madvise(Mapping, Size, MADV_DONTNEED);
----------------
abhina.sreeskantharajan wrote:
> Can this be #endif instead of #else? Not sure if this counts as not using an else after return.
IIUC what you're suggesting, we'd end up including the problem callsite bellow then, so I think we need to keep this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116603/new/

https://reviews.llvm.org/D116603