[PATCH] D116660: [LoopFlatten] Update MemorySSA state

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopFlatten.cpp:824
 
+  Optional<MemorySSAUpdater> MSSAU;
+   if (AR.MSSA) {
----------------
SjoerdMeijer wrote:
> SjoerdMeijer wrote:
> > fhahn wrote:
> > > Could `MSSAU` be created unconditionally like with the legacy pass manager?
> > Thanks for taking a look.
> > 
> > I borrowed this boilerplate code from SimpleLoopUnswitch, but sure, I guess so and will add that.
> > 
> Hmm, I see this pattern used in most passes, like LoopRotation, LoopSimplifyCFG (SimpleLoopUnswitch).
> 
> For my understanding, what would be the benefit of doing this unconditionally?
slightly less & more straight-forward code?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116660/new/

https://reviews.llvm.org/D116660