[PATCH] D113552: [yaml2obj][XCOFF] parsing auxiliary symbols.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, except for one nit, but please also make sure @DiggerLin is happy.



================
Comment at: llvm/lib/ObjectYAML/XCOFFEmitter.cpp:516
+  else
+    ErrHandler("unknown auxiliary symbol type: " + Twine(AuxSym->Type));
+}
----------------
Esme wrote:
> jhenderson wrote:
> > I don't think you've got a test case for this case?
> In fact, this is a `llvm_unreachable` case because the `XCOFFYAML::AuxSymbolType AuxType` is a required field in Yaml input and a case with `unknown auxiliary symbol type` can't be generated in Yaml.
If it's unreachable, why not use `llvm_unreachable`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113552/new/

https://reviews.llvm.org/D113552