[PATCH] D116581: [Aarch64] Customer lowering of COPYSIGN to SIMD should check for NEON availability

Wed Jan 5 03:22:51 PST 2022

dmgreen added inline comments.

================
Comment at: llvm/test/CodeGen/AArch64/fcopysign.ll:2
 ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
-; RUN: llc -o - %s | FileCheck %s
+; RUN: llc < %s -march=aarch64 -mattr -neon | FileCheck -check-prefix=CHECK-NONEON %s
 ; Check that selection dag legalization of fcopysign works in cases with
----------------
Can you make sure there is a "with neon" and a "without neon" run line. That way we test both cases.

The update script doesn't remove old CHECK lines that have been removed fro the RUN lines - those need to be removed manually (or keep the old run lines with the same check-prefix, they should then be updated).

================
Comment at: llvm/test/CodeGen/AArch64/fcopysign.ll:13

 define fp128 @copysign0() {
 ; CHECK-LABEL: copysign0:
----------------
This file only seems to contain f128 copysigns. Can we make sure there are f64/f32/f16 tests too?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116581/new/

https://reviews.llvm.org/D116581