[PATCH] D113104: add the xcoff symbol size for the llvm-nm.
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 5 02:48:51 PST 2022
jhenderson added inline comments.
================
Comment at: llvm/test/tools/llvm-nm/XCOFF/size.test:47
+
+## Size of a label symbol.
+# CHECK: 00000000 00000000 T ._ZL5func0v
----------------
You can delete "Size of a" from each of these comments. Just "Label symbol." etc is sufficient.
================
Comment at: llvm/test/tools/llvm-nm/XCOFF/size.test:13-19
+ - Name: .text
+ Address: 0x0
+ Flags: [ STYP_TEXT ]
+ - Name: .data
+ Flags: [ STYP_DATA ]
+ - Name: .bss
+ Flags: [ STYP_BSS ]
----------------
DiggerLin wrote:
> jhenderson wrote:
> > Remove excessive spacing. Do you need the `Address: 0x0` line?
> the yaml2obj will default to 0x0 if not specific the address.
Right, so if the default is 0x0, why do you need to specify an explicit 0x0?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113104/new/
https://reviews.llvm.org/D113104
More information about the llvm-commits
mailing list