[PATCH] D112450: support xcoff for llvm-nm

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 5 02:37:14 PST 2022


jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-nm/XCOFF/basic.test:93
+
+## Global weak symbol show type char 'W'.
+# CHECK:      00000000 W ._Z3fwpv
----------------
As stated in my earlier comment, there's no need to state "show type char 'W'" or equivalent in the following comments. Please delete.


================
Comment at: llvm/test/tools/llvm-nm/XCOFF/basic_64.test:1
+## Test showing 8 bytes address for llvm-nm for XCOFF 64bits object files.
+
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112450/new/

https://reviews.llvm.org/D112450



More information about the llvm-commits mailing list