[PATCH] D116551: [AVR] Mark call-clobbered registers as clobbered in interrupt handlers

[Ben Shi via Phabricator via llvm-commits]

benshi001 added a comment.

Generally speaking, I am OK with this patch. Just one suggestion, run `llvm/utils/update_llc_test_checks.py` against the test `case llvm/test/CodeGen/AVR/interrupts.ll`



================
Comment at: llvm/test/CodeGen/AVR/interrupts.ll:1
 ; RUN: llc < %s -march=avr | FileCheck %s
 
----------------
Would it be better to add an option `-verify-machineinstrs` ?


================
Comment at: llvm/test/CodeGen/AVR/interrupts.ll:115
+; CHECK-NEXT: push r0
+; CHECK:      clr r0
+; CHECK-NEXT: clr r1
----------------
Why this is a `CHECK` not a `CHECK-NEXT` ? Would it be better to show all auto generated assembly ?


================
Comment at: llvm/test/CodeGen/AVR/interrupts.ll:145
+; CHECK-NEXT: clr r1
+; CHECK:      push r18
+; CHECK-NEXT: push r19
----------------
Why this is a `CHECK` not a `CHECK-NEXT` ? Would it be better to show all auto generated assembly ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116551/new/

https://reviews.llvm.org/D116551