[PATCH] D115859: [LoongArch 2/6] Add ELF machine flag and relocs for upcoming LoongArch target

Wed Jan 5 02:24:19 PST 2022

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, but worth giving it a bit longer for others to finish commenting on too.

================
Comment at: llvm/test/tools/llvm-readobj/ELF/reloc-types-elf-loongarch64.test:1
+## Test that llvm-readobj/llvm-readelf shows proper relocation type
+## names and values for loongarch64 target.
----------------
MaskRay wrote:
> SixWeining wrote:
> > jhenderson wrote:
> > > You can drop "elf" from the title of this test, since it's already in the `ELF` subdirectory.
> > Good suggestion. But we just follow other existing files naming method in the same directory. Maybe we can change all these files in a seperate patch later.
> I will do the file renames for other `reloc-types-elf-*` tests (D71203) @grimar 
(just noting to make sure that if @MaskRay does this first, to make sure you rename this file before it lands)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115859/new/

https://reviews.llvm.org/D115859