[PATCH] D116469: [AMDGPU] Correct the known bits calculation for MUL_I24.

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 5 01:54:09 PST 2022


foad added a comment.

In D116469#3220809 <https://reviews.llvm.org/D116469#3220809>, @craig.topper wrote:

> In D116469#3219140 <https://reviews.llvm.org/D116469#3219140>, @foad wrote:
>
>> This patch seems to change codegen in test/CodeGen/AMDGPU/lshl64-to-32.ll but I haven't managed to understand whether the change is good, bad or indifferent.
>
> I'm not seeing any failure for that test in my local runs. The test appears to be generated by update_llc_test_checks.py and rerunning the script produced no changes. Am I missing something?

Sorry, false alarm. I had to manually rebase the patch when I tested it, and I got it wrong.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116469/new/

https://reviews.llvm.org/D116469



More information about the llvm-commits mailing list