[PATCH] D114735: [lld][macho] Stop grouping symbols by sections in mapfile.

Wed Jan 5 01:39:56 PST 2022

int3 accepted this revision.
int3 added a comment.
This revision is now accepted and ready to land.

@MaskRay makes sense, but I think it's more important that we can act as a drop-in replacement for ld64. We can certainly add support for a different mapfile format in the future.

================
Comment at: lld/test/MachO/map-file.s:49-51
 # CHECK-NEXT: 0x[[#MAIN]]      [  1]  _main
 # CHECK-NEXT: 0x[[#FOO]]       [  2]  _foo
+# CHECK-NEXT: 0x[[#NUMBER]]    [  1]  _number
----------------
Roger wrote:
> int3 wrote:
> > hmm why did the ordering change? and what does ld64 output here?
> Since we are no longer grouping symbols by their sections, the order in which they appear will change. I updated the description to include what ld64's mapfile looks like for this example. Aside from the "compact unwind info" that ld64 has that lld does not, the ordering is the same. WDYT?
oh so this makes us more correct then -- excellent!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114735/new/

https://reviews.llvm.org/D114735