[PATCH] D115973: [llvm-profgen] Support symbol loading for debug fission

[Alexander Yermolovich via Phabricator via llvm-commits]

ayermolo added inline comments.


================
Comment at: llvm/tools/llvm-profgen/ProfiledBinary.cpp:685
+      DWARFUnit *DWOCU = DwarfUnit->getNonSkeletonUnitDIE(false).getDwarfUnit();
+      if (!DWOCU->isDWOUnit()) {
+        std::string DWOName = dwarf::toString(
----------------
wlei wrote:
> hoy wrote:
> > What is a DWO unit checked against here? Is it an indirection to the real compilation unit?
> I think it's an internal check whether the current parsed result is a DWO unit.
> The `getNonSkeletonUnitDIE` is expected to get a DWOUnit, if the parsing failed and not a DWOUnit, it's likely due to the incorrect dwo file path.
Right. It's a bit weird implementation. If it fails to parse and produce DWO Die it invokes getUnitDIE and returns a Die for Skeleton CU.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115973/new/

https://reviews.llvm.org/D115973