[PATCH] D116584: [RISCV] Block vmsleu.vx/vmsgeu.vi with 0 immediate in Isel

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

Shouldn't you remove VPatCompareUnsignedZero from RISCVInstrInfoVPseudos.td?



================
Comment at: llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp:817
       break;
+    case Intrinsic::riscv_vmsltu: {
+      SDValue Src1 = Node->getOperand(1);
----------------
This could be done by using a new version of simm5_plus1 that excludes 0 in VPatCompare_VI for the vmsltu case.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp:863
+    }
+    case Intrinsic::riscv_vmsltu_mask: {
+      SDValue Src1 = Node->getOperand(2);
----------------
Same here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116584/new/

https://reviews.llvm.org/D116584