[PATCH] D116180: [InstrProf] Add single byte coverage mode

Kyungwoo Lee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 4 16:45:48 PST 2022


kyulee added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:947
+    std::vector<Constant *> InitialValues(NumCounters,
+                                          Constant::getAllOnesValue(CounterTy));
+    CounterPtr = new GlobalVariable(
----------------
Can we just use `Constant::getAllOnesValue()` like `Constant::getNullValue()` with the array type?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116180/new/

https://reviews.llvm.org/D116180



More information about the llvm-commits mailing list