[PATCH] D116589: Don't override __attribute__((no_stack_protector)) by inlining

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers accepted this revision.
nickdesaulniers added inline comments.


================
Comment at: llvm/test/Transforms/Inline/inline_ssp.ll:2
 ; RUN: opt -inline %s -S | FileCheck %s
 ; RUN: opt -passes='cgscc(inline)' %s -S | FileCheck %s
 ; Ensure SSP attributes are propagated correctly when inlining.
----------------
I think there's a pass called `always-inline`, too. Should we add that as a run line?


================
Comment at: llvm/test/Transforms/Inline/inline_ssp.ll:50
 entry:
-; CHECK: @inline_req_req() #0
+; CHECK: @inline_req_req() #[[SSPREQ:[0-9]]]
   call void @fun_sspreq()
----------------
converting all of these attribute checks to regexes can also probably be pre-committed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116589/new/

https://reviews.llvm.org/D116589