[PATCH] D116434: [lld-link] Replace LazyObjFile with lazy ObjFile/BitcodeFile

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 4 14:06:37 PST 2022


rnk accepted this revision.
rnk added a comment.

Looks good to me



================
Comment at: lld/COFF/SymbolTable.cpp:42
+    if (auto *f = dyn_cast<BitcodeFile>(file))
+      f->parseLazy();
+    else
----------------
If `parse` is virtual, should `parseLazy` be virtual as well? Doing O(objects) virtual calls shouldn't matter for performance, it's the O(symbols) actions that matter.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116434/new/

https://reviews.llvm.org/D116434



More information about the llvm-commits mailing list