[PATCH] D115847: [mlgo][inline] Improve global state tracking

[Petr Hosek via Phabricator via llvm-commits]

phosek added a comment.

This looks reasonable although I'm not familiar with this part of the codebase so I'd like for @aeubanks to take a look as well.



================
Comment at: llvm/include/llvm/Analysis/MLInlineAdvisor.h:78
+  // Nodes that were invalidated in any manner, including function replacement
+  // (which would include a delete of the old function)
+  DenseSet<const LazyCallGraph::Node *> NodesToRefresh;
----------------



================
Comment at: llvm/lib/Analysis/MLInlineAdvisor.cpp:155
+  // module-wide features. If nodes were added, as we can't determine which
+  // those were, we need to revisit the module (slow)
+  if (LastTotalNodeCount != LCG.totalNodeCount())
----------------



================
Comment at: llvm/test/Transforms/Inline/ML/state-tracking.ll:25
+}
\ No newline at end of file

----------------
Can you add a newline here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115847/new/

https://reviews.llvm.org/D115847