[PATCH] D116603: [AIX][z/OS][Support] Provide alternate mapped_file_region::dontNeedImpl implementations

Zibi Sarbino via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 4 10:56:56 PST 2022


zibi added inline comments.


================
Comment at: llvm/lib/Support/Unix/Path.inc:875
   assert(Mode == mapped_file_region::readonly);
   if (Mapping)
+#if defined(__MVS__)
----------------
aganea wrote:
> Shouldn't we protect the contents of this function with `#ifdef HAVE_SYS_MMAN_H`?
I don't think we can use HAVE_SYS_MMAN_H since this is defined on z/OS since we do have `sys/mman.h` header file. We just don't have `madvise()`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116603/new/

https://reviews.llvm.org/D116603



More information about the llvm-commits mailing list