[PATCH] D116574: Materializing constants with 'rori'

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/imm_zbb.ll:1
+; RUN: llc -mtriple=riscv64 -mattr=+experimental-zbb \
+; RUN:   -verify-machineinstrs < %s | FileCheck %s -check-prefix=RV64IZBB
----------------
Please add a test for the MC layer for the "li"  alias as well since it shares the same materialization code.


================
Comment at: llvm/test/CodeGen/RISCV/imm_zbb.ll:7
+
+; Function Attrs: mustprogress nofree norecurse nosync nounwind readnone willreturn
+define dso_local i64 @li_rori_1() local_unnamed_addr #0 {
----------------
Drop the Function Attrs comment.


================
Comment at: llvm/test/CodeGen/RISCV/imm_zbb.ll:8
+; Function Attrs: mustprogress nofree norecurse nosync nounwind readnone willreturn
+define dso_local i64 @li_rori_1() local_unnamed_addr #0 {
+; RV64IZBB-LABEL: li_rori_1:
----------------
drop dso_local, local_unnamed_addr, and #0


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116574/new/

https://reviews.llvm.org/D116574