[PATCH] D116139: [ORC-RT] Add debug logging macros.

[Ben Langmuir via Phabricator via llvm-commits]

benlangmuir added a comment.

Handling "" as enabling all logging is a bit strange to me -- what was the reasoning for that? LGTM other than than the return value from `initializeDebug` that I mentioned.



================
Comment at: compiler-rt/lib/orc/debug.cpp:41
+    DebugTypes.store(&DebugTypesNone, std::memory_order_relaxed);
+    return &DebugTypesAll;
+  }
----------------
Should return `&DebugTypesNone`, I think.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116139/new/

https://reviews.llvm.org/D116139