[PATCH] D116322: [Analysis] allow caller to choose signed/unsigned when computing constant range

[Sanjay Patel via Phabricator via llvm-commits]

spatel added inline comments.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:7149
+      ConstantRange RHS =
+          computeConstantRange(Cmp->getOperand(1), UseInstrInfo,
+                               /* ForSigned */ false, AC, I, DT, Depth + 1);
----------------
anna wrote:
> just noticed this while reading the code. The bool arguments are swapped here. Should be:
> ```
> computeConstantRange(Cmp->getOperand(1), /* ForSigned */ false, UseInstrInfo, AC, I, DT, Depth + 1);
> ```
Thanks for reviewing!
1e50d064666f


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116322/new/

https://reviews.llvm.org/D116322