[PATCH] D116333: [RISCV] Initial support for scalable vectorization

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 4 09:48:34 PST 2022


jrtc27 added inline comments.


================
Comment at: llvm/test/Transforms/LoopVectorize/RISCV/scalable-vectorization.ll:10
+define void @test0(i32* %a, i8* %b, i32* %c) #0 {
+; CHECK: LV: Checking a loop in "test0"
+; CHECK_SCALABLE_ON: LV: Found feasible scalable VF = vscale x 2
----------------
alextsao1999 wrote:
> jrtc27 wrote:
> > Not actually showing the code generated? Debug output is generally not great for testing, it's often unclear what's actually going on, it can only run in builds that have debugging built in and you have to write the CHECK lines by hand.
> The test case is from sve, so I think it's better to be consistent with sve...
I disagree. Some other targets have some utterly crap tests, we don't need to copy them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116333/new/

https://reviews.llvm.org/D116333



More information about the llvm-commits mailing list