[PATCH] D116589: Don't override __attribute__((no_stack_protector)) by inlining

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers added a comment.

Please add a link to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94722 in the commit description.



================
Comment at: llvm/test/ThinLTO/X86/nossp.ll:26
 define void @nossp_caller() {
-; CHECK-LABEL: @nossp_caller
+; CHECK: define void @nossp_caller() local_unnamed_addr {
 ; CHECK-NEXT: tail call void @foo
----------------
is `local_unnamed_addr` necessary for these tests?


================
Comment at: llvm/test/ThinLTO/X86/nossp.ll:34
 define void @ssp_caller() ssp {
-; CHECK-LABEL: @ssp_caller
+; CHECK: define void @ssp_caller() local_unnamed_addr #0 {
 ; CHECK-NEXT: tail call void @foo
----------------
Please put the attribute inline; it's much more readable for this single attribute.


================
Comment at: llvm/test/Transforms/Inline/inline_ssp.ll:150
 
 define void @inline_nossp_nossp() nounwind uwtable {
 entry:
----------------
`nounwind uwtable` adds a lot of noise to this test. I wouldn't mind if you pre-committed a change removing them. ;)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116589/new/

https://reviews.llvm.org/D116589