[PATCH] D113633: [llvm] Add support for DW_TAG_immutable_type

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

Code looks quite reasonable; the test needs a little cleanup.



================
Comment at: llvm/test/DebugInfo/dwarfdump-immutable.ll:3
+;; is accepted and processed.
+; REQUIRES: x86_64-linux
+
----------------
I believe you can remove the REQUIRES, explicit triple on the `llc` command, and the `target triple` IR clause, to allow this to work generically; there doesn't really seem to be anything X86-specific here.  You'll want to use `%llc_dwarf` instead of `llc` as the command, which will insert an appropriate triple for hosts that don't implicitly use DWARF.  See other examples of this in the same test directory.


================
Comment at: llvm/test/DebugInfo/dwarfdump-immutable.ll:9
+
+; CHECK-LABEL: DW_TAG_immutable_type
+
----------------
This should be just `CHECK:` not `CHECK-LABEL:`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113633/new/

https://reviews.llvm.org/D113633