[PATCH] D109584: Implementing expansion pass for VP load and store.

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 4 09:19:24 PST 2022


frasercrmck added a comment.

This needs "generic" testing e.g. like those in `test/CodeGen/Generic/expand-vp.ll`



================
Comment at: llvm/lib/CodeGen/ExpandVectorPredication.cpp:539
+Value *
+CachingVPExpander::expandPredicationInUnfoldedLoadStore(IRBuilder<> &Builder,
+                                                        VPIntrinsic &VPI) {
----------------
I wonder if the addition of this method should be in a follow-up patch?  That is, first get the "basic" support in using `masked.*` intrinsics in and consider this an enhancement/optimization for certain targets like PowerPC?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109584/new/

https://reviews.llvm.org/D109584



More information about the llvm-commits mailing list