[PATCH] D115356: [LV] Remove what seems like stale code in collectElementTypesForWidening.

David Sherwood via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 4 07:05:39 PST 2022


david-arm accepted this revision.
david-arm added a comment.
This revision is now accepted and ready to land.

LGTM. I don't see why we should be treating stores/loads involving 64-bit pointers any different to normal 64-bit values. Furthermore, there are no existing tests defending the case where VF>1, which suggests the removed code has little value. If we have an accurate cost model that reflects the cost of scalarising gathers/scatters then that should ensure a sensible choice of interleave count.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115356/new/

https://reviews.llvm.org/D115356



More information about the llvm-commits mailing list