[PATCH] D106378: RISCV: relax the ABI mismatch checking

[Jérémie Courrèges-Anglas via Phabricator via llvm-commits]

jca added a comment.

I think there is a problem with how code sections are matched.



================
Comment at: lld/ELF/Arch/RISCV.cpp:128
+    if (sections.size() && llvm::any_of(sections, [](const auto *section) {
+          return (section && (section->flags & (SHF_ALLOC | SHF_EXECINSTR)));
+        })) {
----------------
This test seems too broad to only match loaded machine code sections.  You need to check whether both flags are set.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106378/new/

https://reviews.llvm.org/D106378