[PATCH] D115329: [LoopVectorize] Pass a vector type to isLegalMaskedGather/Scatter

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

Are the X86 behavior changes intentional?



================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:1586
   /// predication for that VF.
-  bool isScalarWithPredication(Instruction *I) const;
+  bool isScalarWithPredication(Instruction *I, ElementCount VF) const;
 
----------------
documentation needs to be updated.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:1591
   // Superset of instructions that return true for isScalarWithPredication.
-  bool isPredicatedInst(Instruction *I, bool IsKnownUniform = false) {
+  bool isPredicatedInst(Instruction *I, ElementCount VF,
+                        bool IsKnownUniform = false) {
----------------
VF should be documented.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115329/new/

https://reviews.llvm.org/D115329