[PATCH] D116522: [ValueTracking][SelectionDAG] Rename ComputeMinSignedBits->ComputeMaxSignificantBits. NFC
Jay Foad via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 4 01:19:23 PST 2022
foad added a comment.
> Rename APInt::getMinSignedBits->getSignificantBits
Why drop "Signed" from the name? Now we have `getActiveBits` for the unsigned version of this functionality and `getSignificantBits` for the signed version, which I don't think is very intuitive.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116522/new/
https://reviews.llvm.org/D116522
More information about the llvm-commits
mailing list