[PATCH] D116528: [ELF] Handle .init_array prefix consistently

[Nikita Popov via Phabricator via llvm-commits]

This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
nikic marked 2 inline comments as done.
Closed by commit rG4ef560ec6026: [ELF] Handle .init_array prefix consistently (authored by nikic).

Changed prior to commit:
  https://reviews.llvm.org/D116528?vs=397023&id=397221#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116528/new/

https://reviews.llvm.org/D116528

Files:
  llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp
  llvm/test/CodeGen/X86/attribute-sections.ll


Index: llvm/test/CodeGen/X86/attribute-sections.ll
===================================================================
--- llvm/test/CodeGen/X86/attribute-sections.ll
+++ llvm/test/CodeGen/X86/attribute-sections.ll
@@ -1,18 +1,36 @@
-; RUN: llc < %s -mtriple=i386-unknown-linux-gnu | FileCheck %s -check-prefix=LINUX
+; RUN: llc < %s -mtriple=i386-unknown-linux-gnu | FileCheck %s
 
 declare i32 @foo()
- at G0 = global i32 ()* @foo, section ".init_array"
 
-; LINUX:  .section  .init_array,"aw"
-; LINUX:  .globl G0
+ at init_array1 = global i32 ()* @foo, section ".init_array"
+ at init_array2 = global i32 ()* @foo, section ".init_array.00001"
+ at init_array3 = global i32 ()* @foo, section ".init_arrayfoo"
 
- at G1 = global i32 ()* @foo, section ".fini_array"
+; CHECK-LABEL: .section  .init_array,"aw", at init_array
+; CHECK: init_array1:
+; CHECK-LABEL: .section  .init_array.00001,"aw", at init_array
+; CHECK: init_array2:
+; CHECK-LABEL: .section  .init_arrayfoo,"aw", at progbits
+; CHECK: init_array3:
 
-; LINUX:  .section  .fini_array,"aw"
-; LINUX:  .globl G1
+ at fini_array1 = global i32 ()* @foo, section ".fini_array"
+ at fini_array2 = global i32 ()* @foo, section ".fini_array.00001"
+ at fini_array3 = global i32 ()* @foo, section ".fini_arrayfoo"
 
- at G2 = global i32 ()* @foo, section ".preinit_array"
+; CHECK-LABEL: .section  .fini_array,"aw", at fini_array
+; CHECK: fini_array1:
+; CHECK-LABEL: .section  .fini_array.00001,"aw", at fini_array
+; CHECK: fini_array2:
+; CHECK-LABEL: .section  .fini_arrayfoo,"aw", at progbits
+; CHECK: fini_array3:
 
-; LINUX:  .section .preinit_array,"aw"
-; LINUX:  .globl G2
+ at preinit_array1 = global i32 ()* @foo, section ".preinit_array"
+ at preinit_array2 = global i32 ()* @foo, section ".preinit_array.00001"
+ at preinit_array3 = global i32 ()* @foo, section ".preinit_arrayfoo"
 
+; CHECK-LABEL: .section  .preinit_array,"aw", at preinit_array
+; CHECK: preinit_array1:
+; CHECK-LABEL: .section  .preinit_array.00001,"aw", at preinit_array
+; CHECK: preinit_array2:
+; CHECK-LABEL: .section  .preinit_arrayfoo,"aw", at progbits
+; CHECK: preinit_array3:
Index: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp
===================================================================
--- llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp
+++ llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp
@@ -478,6 +478,11 @@
   return K;
 }
 
+static bool hasPrefix(StringRef SectionName, StringRef Prefix) {
+  return SectionName.consume_front(Prefix) &&
+         (SectionName.empty() || SectionName[0] == '.');
+}
+
 static unsigned getELFSectionType(StringRef Name, SectionKind K) {
   // Use SHT_NOTE for section whose name starts with ".note" to allow
   // emitting ELF notes from C variable declaration.
@@ -485,13 +490,13 @@
   if (Name.startswith(".note"))
     return ELF::SHT_NOTE;
 
-  if (Name == ".init_array")
+  if (hasPrefix(Name, ".init_array"))
     return ELF::SHT_INIT_ARRAY;
 
-  if (Name == ".fini_array")
+  if (hasPrefix(Name, ".fini_array"))
     return ELF::SHT_FINI_ARRAY;
 
-  if (Name == ".preinit_array")
+  if (hasPrefix(Name, ".preinit_array"))
     return ELF::SHT_PREINIT_ARRAY;
 
   if (K.isBSS() || K.isThreadBSS())


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D116528.397221.patch
Type: text/x-patch
Size: 3153 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220104/9f3f5797/attachment.bin>