[PATCH] D116400: [LegalizeTypes][VP] Add integer promotion support for vp.select
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 3 22:22:25 PST 2022
craig.topper added inline comments.
================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:1143
+ if (!IsVP)
+ return DAG.getSelect(SDLoc(N), LHS.getValueType(), Mask, LHS, RHS);
+ return DAG.getNode(N->getOpcode(), SDLoc(N), LHS.getValueType(), Mask, LHS,
----------------
Use `getNode(N->getOpcode()` to match the widening patch and avoid a runtime check for of the condition type to pick the opcode.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116400/new/
https://reviews.llvm.org/D116400
More information about the llvm-commits
mailing list