[PATCH] D93298: [RISCV] add the part of MC layer support of Zfinx extension

[Shao-Ce SUN via Phabricator via llvm-commits]

achieveartificialintelligence added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoF.td:217
+let Predicates = [HasStdExtF] in {
+def : FPFMADynFrmAlias<FMADD_S,  "fmadd.s",  FPR32Op>;
+def : FPFMADynFrmAlias<FMSUB_S,  "fmsub.s",  FPR32Op>;
----------------
craig.topper wrote:
> Why do the aliases not apply to Zfinx?
Because the first argument is `FPFMA_rrr_frm Inst`, if we use multiclass here, it'll be `FFPFMA_rrr_frm Inst, FFPFMA_rrr_frm Inst_INX`. I don't know is there a better way?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93298/new/

https://reviews.llvm.org/D93298