[PATCH] D93298: [RISCV] add the part of MC layer support of Zfinx extension

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a subscriber: khchen.
craig.topper added inline comments.


================
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:290
 
+    if (ExtName == "zdinx")
+      Features.push_back("+zfinx");
----------------
@kito-cheng or @khchen is the right way to do this? Or should it be in updateImplication? Where do we have Zfhmin imply f or d imply f today?


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoD.td:34
+  let Name = "GPRPF64AsFPR";
+  let ParserMethod = "parseGPRAsFPR";
+}
----------------
Can you add `let RenderMethod = "addRegOperands";` here. That should let you remove `addGPRAsFPROperands` from RISCVAsmParser.cpp. Similar for the other AsmOperandClasses.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93298/new/

https://reviews.llvm.org/D93298