[PATCH] D116465: [SPIRV 6/6] Add 2 essential passes and the simplest tests

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/test/CodeGen/SPIRV/optnone.ll:6
+; FunctionControlDontInlineMask = 0x2 (2)
+; CHECK-SPIRV-NO-EXT: %{{[0-9]+}} = OpFunction %{{[0-9]+}} DontInline
+
----------------
Without a positive test in the same file, a negative pattern can easily go stale without being noticed.

Consider `split-file` to place highly related tests together.


================
Comment at: llvm/test/CodeGen/SPIRV/optnone.ll:17
+
+attributes #0 = { nounwind optnone noinline "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "less-precise-fpmad"="false" "min-legal-vector-width"="0" "no-frame-pointer-elim"="false" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "stack-protector-buffer-size"="8" "unsafe-fp-math"="false" "use-soft-float"="false" }
+
----------------
delete unneeded attributes


================
Comment at: llvm/test/CodeGen/SPIRV/optnone.ll:27
+!2 = !{i32 4, i32 100000}
+!3 = !{!"clang version 9.0.0"}
+!4 = !{}
----------------
incorrect version.

delete unneeded metadata


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116465/new/

https://reviews.llvm.org/D116465