[PATCH] D115009: [SPIRV 1/6] Add stub for SPIRV backend

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 3 15:59:43 PST 2022


MaskRay added a comment.

Other than the regular `-DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=on` builds, it's good to ensure a few others work:

- `-DBUILD_SHARED_LIBS=on` ensure CMake build dependency is correct. The mode uses `-Wl,-z,defs` to link shared objects. It has some dependency checking effects: https://maskray.me/blog/2021-06-13-dependency-related-linker-options#z-defs)
- `-DLLVM_LINK_LLVM_DYLIB=on -DCLANG_LINK_CLANG_DYLIB=on`: somewhat covered by `-DBUILD_SHARED_LIBS=on`, but not bad to ensure it works as many Linux distros have shifted to this mode
- `-DLLVM_ENABLE_EXPENSIVE_CHECKS=on -DLLVM_ENABLE_ABI_BREAKING_CHECKS=on`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115009/new/

https://reviews.llvm.org/D115009



More information about the llvm-commits mailing list