[PATCH] D115987: [AVR][MC] Generate section '.progmemX.data' for extended flash banks

Ayke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 3 12:34:03 PST 2022


aykevl added a comment.

I wonder whether we should generate an error instead of falling back to other memory areas? That would be more consistent with avr-gcc and I think that would also be more correct.



================
Comment at: llvm/test/CodeGen/AVR/sections.ll:32
+; CHECK-LABEL: flash1:
+; CHECK8515-NOT: .section .progmem1.data,"a", at progbits
+; CHECK8515-LABEL: flash1:
----------------
Why not check for what it should be, instead of what it should not be? Something like this (untested):

```
; CHECK8515: .section .data,"a"
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115987/new/

https://reviews.llvm.org/D115987



More information about the llvm-commits mailing list