[PATCH] D116522: [ValueTracking][SelectionDAG] Rename ComputeMinSignedBits->ComputeMaxSignificantBits. NFC

[Sanjay Patel via Phabricator via llvm-commits]

spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM - someday we might fix the capitalization of function names too. :)



================
Comment at: llvm/include/llvm/Analysis/ValueTracking.h:207
+  /// i.e.  x == sext(trunc(x to MaxSignificantBits) to bitwidth(x)).
+  /// Similar to the APInt::getMaxSignificantBits function.
+  unsigned ComputeMaxSignificantBits(const Value *Op, const DataLayout &DL,
----------------
That should be "APInt::getSignificantBits function" (no "Max")?


================
Comment at: llvm/include/llvm/CodeGen/SelectionDAG.h:1838
+  /// i.e.  x == sext(trunc(x to MaxSignedBits) to bitwidth(x)).
+  /// Similar to the APInt::getMaxSignedBits function.
   /// Helper wrapper to ComputeNumSignBits.
----------------
That should be "APInt::getSignificantBits function" (no "Max")?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116522/new/

https://reviews.llvm.org/D116522