[PATCH] D116540: [OpenMP] Add nvidia as a compiler vendor for OpenMP

Mon Jan 3 09:13:43 PST 2022

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

In D116540#3217684 <https://reviews.llvm.org/D116540#3217684>, @saiislam wrote:

> 1. I don't know why "pgi" is present here as a vendor. Should it be renamed as nvidia instead? @Meinersbur @tra

It was in the spec list and I would not remove it now.

> 1. Should "cray" be renamed as "hpe" here? @sandoval

No, both are listed in the spec.

> 1. Should this vendor list be reordered as per Spec 5.1 [https://www.openmp.org/wp-content/uploads/OpenMP-API-Additional-Definitions-2-0.pdf] ?

It was ordered as per that spec, which is just alphabetical. Can you add `nec` as well and keep the others please.

LG, see above.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116540/new/

https://reviews.llvm.org/D116540