[PATCH] D115955: [SLP]Alternate vectorization for cmp instructions.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:438
   /// Some of the instructions in the list have alternate opcodes.
-  bool isAltShuffle() const { return getOpcode() != getAltOpcode(); }
+  bool isAltShuffle() const { return AltOp != MainOp; }
 
----------------
Pull this change out as a pre-commit? I can't recall if we had a reason to use getOpcode()/getAltOpcode() (and the null handling) or not.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:2083
     bool isAltShuffle() const {
-      return getOpcode() != getAltOpcode();
+      return MainOp != AltOp;
     }
----------------
Pull this change out as a pre-commit?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115955/new/

https://reviews.llvm.org/D115955