[PATCH] D116522: [ValueTracking][SelectionDAG] Rename ComputeMinSignedBits->ComputeMaxSignedBits. NFC

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon accepted this revision.
RKSimon added a comment.

LGTM - with one (very pedantic) minor



================
Comment at: llvm/include/llvm/Analysis/ValueTracking.h:205
 
   /// Get the minimum bit size for this Value \p Op as a signed integer.
+  /// i.e.  x == sext(trunc(x to MaxSignedBits) to bitwidth(x)).
----------------
The use of minimum might be confusing - please can you tweak the description?


================
Comment at: llvm/include/llvm/CodeGen/SelectionDAG.h:1836
 
   /// Get the minimum bit size for this Value \p Op as a signed integer.
+  /// i.e.  x == sext(trunc(x to MaxSignedBits) to bitwidth(x)).
----------------
Tweak the description?


================
Comment at: llvm/include/llvm/CodeGen/SelectionDAG.h:1842
 
   /// Get the minimum bit size for this Value \p Op as a signed integer.
+  /// i.e.  x == sext(trunc(x to MaxSignedBits) to bitwidth(x)).
----------------
Tweak the description?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116522/new/

https://reviews.llvm.org/D116522