[PATCH] D116531: [LangRef] Require elementtype attribute for indirect inline asm operands

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.

Seems fine to me.
Thanks.



================
Comment at: llvm/test/Verifier/inline-asm-indirect-operand.ll:15-20
+; CHECK: Operand for indirect constraint must have pointer type
+; CHECK-NEXT: call void asm "addl $1, $0", "=*rm,r"(i32 %p, i32 %x)
+define void @not_pointer_arg(i32 %p, i32 %x) {
+	call void asm "addl $1, $0", "=*rm,r"(i32 %p, i32 %x)
+  ret void
+}
----------------
Worth testing that the checking is done for call/invoke/asm goto, not just call?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116531/new/

https://reviews.llvm.org/D116531