[PATCH] D80860: Exact integer emptiness checks for FlatAffineConstraints

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: mlir/lib/Analysis/Presburger/Simplex.cpp:325
+
+    int64_t diff = retConst * elem - constTerm * retElem;
+    if ((diff == 0 && rowUnknown[row] < rowUnknown[*retRow]) ||
----------------
mehdi_amini wrote:
> If `retRow` is true, then `retConst` is used uninitialized right? Can you look into this?
> (flagged by Coverity)
(Same with  `retElem`)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80860/new/

https://reviews.llvm.org/D80860