[PATCH] D116484: [lld][MinGW] Ignore `--[no-]as-neeed` flags in MinGW driver

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 2 18:52:16 PST 2022


MaskRay added a comment.

In D116484#3216485 <https://reviews.llvm.org/D116484#3216485>, @mstorsjo wrote:

> In D116484#3216409 <https://reviews.llvm.org/D116484#3216409>, @MaskRay wrote:
>
>> Unless there are motivating examples that some options are incorrectly used in a prevailing way, it doesn't seem right to ignore options from another binary format which cannot be properly modeled.
>
> As linking against DLL import libraries kinda works like `--as-needed` (only ending up with a runtime dependency if symbols actually are referenced), would you consider accepting `--as-needed` but omitting `--no-as-needed`?

Then ignoring `--as-needed` sounds good. `--no-as-needed` is like an error which should not be ignored.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116484/new/

https://reviews.llvm.org/D116484



More information about the llvm-commits mailing list