[llvm] 9a2120a - [llvm-profgen] Error out for unsupported AutoFDO profile generate with probe

Wenlei He via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 2 16:40:31 PST 2022


Author: Wenlei He
Date: 2022-01-02T16:38:56-08:00
New Revision: 9a2120a6e1fcefbfabbe8d25f14e056fadc37f2d

URL: https://github.com/llvm/llvm-project/commit/9a2120a6e1fcefbfabbe8d25f14e056fadc37f2d
DIFF: https://github.com/llvm/llvm-project/commit/9a2120a6e1fcefbfabbe8d25f14e056fadc37f2d.diff

LOG: [llvm-profgen] Error out for unsupported AutoFDO profile generate with probe

Error out instead of siliently generate empty profile when trying to generate AutoFDO profile with probe binary.

Differential Revision: https://reviews.llvm.org/D116508

Added: 
    

Modified: 
    llvm/tools/llvm-profgen/ProfileGenerator.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/tools/llvm-profgen/ProfileGenerator.cpp b/llvm/tools/llvm-profgen/ProfileGenerator.cpp
index f03e407dbe7d7..7155ec4a42191 100644
--- a/llvm/tools/llvm-profgen/ProfileGenerator.cpp
+++ b/llvm/tools/llvm-profgen/ProfileGenerator.cpp
@@ -383,6 +383,8 @@ ProfileGenerator::getTopLevelFunctionProfile(StringRef FuncName) {
 void ProfileGenerator::generateProfile() {
   if (Binary->usePseudoProbes()) {
     // TODO: Support probe based profile generation
+    exitWithError("Probe based profile generation not supported for AutoFDO, "
+      "consider dropping `--ignore-stack-samples` or adding `--use-dwarf-correlation`.");
   } else {
     generateLineNumBasedProfile();
   }


        


More information about the llvm-commits mailing list