[PATCH] D116508: [llvm-profgen] Error out for unsupported AutoFDO profile generate with probe

Wenlei He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 2 16:29:27 PST 2022


wenlei created this revision.
wenlei added reviewers: wlei, hoy.
Herald added a subscriber: modimo.
wenlei requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Error out instead of siliently generate empty profile when trying to generate AutoFDO profile with probe binary.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D116508

Files:
  llvm/tools/llvm-profgen/ProfileGenerator.cpp


Index: llvm/tools/llvm-profgen/ProfileGenerator.cpp
===================================================================
--- llvm/tools/llvm-profgen/ProfileGenerator.cpp
+++ llvm/tools/llvm-profgen/ProfileGenerator.cpp
@@ -383,6 +383,7 @@
 void ProfileGenerator::generateProfile() {
   if (Binary->usePseudoProbes()) {
     // TODO: Support probe based profile generation
+    exitWithError("Probe based profile generation not supported for AutoFDO.");
   } else {
     generateLineNumBasedProfile();
   }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D116508.396964.patch
Type: text/x-patch
Size: 505 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220103/23e4c299/attachment.bin>


More information about the llvm-commits mailing list